Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reactive Jetty web server does not fail fast when configured to use a server name bundle which Jetty does not support #44316

Closed
wilkinsona opened this issue Feb 18, 2025 · 0 comments
Assignees
Labels
type: bug A general bug
Milestone

Comments

@wilkinsona
Copy link
Member

We don't support SNI with Jetty and an attempt to use a server name SSL bundle with a Jetty servlet web server fails fast:

private void customizeSsl(Server server, InetSocketAddress address) {
Assert.state(getSsl().getServerNameBundles().isEmpty(), "Server name SSL bundles are not supported with Jetty");
new SslServerCustomizer(getHttp2(), address, getSsl().getClientAuth(), getSslBundle()).customize(server);
}

A similar assertion should be made on the reactive side:

private void customizeSsl(Server server, InetSocketAddress address) {
new SslServerCustomizer(getHttp2(), address, getSsl().getClientAuth(), getSslBundle()).customize(server);
}

@wilkinsona wilkinsona added the type: bug A general bug label Feb 18, 2025
@wilkinsona wilkinsona added this to the 3.3.x milestone Feb 18, 2025
@wilkinsona wilkinsona self-assigned this Feb 18, 2025
@wilkinsona wilkinsona changed the title Reactive Jetty web server does not fail fast when configured to use a server name bundle which is not supported Reactive Jetty web server does not fail fast when configured to use a server name bundle which Jetty does not support Feb 18, 2025
@wilkinsona wilkinsona modified the milestones: 3.3.x, 3.3.9 Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A general bug
Projects
None yet
Development

No branches or pull requests

1 participant