Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gradle plugin uses to-be-deprecated API for getting and setting file permissions #37878

Closed
jbartok opened this issue Oct 13, 2023 · 4 comments
Closed

Gradle plugin uses to-be-deprecated API for getting and setting file permissions #37878

jbartok opened this issue Oct 13, 2023 · 4 comments
Labels
type: bug A general bug
Milestone
2.7.17

Comments

@jbartok
Copy link

jbartok commented Oct 13, 2023 •
edited by wilkinsona

Gradle 8.3 introduces a new API for setting file permissions.

We intend to deprecate the old, Unix mode based API in Gradle, but we can't do that until major Gradle plugins start using the new one.

For that reason would be good to upgrade this plugin to use Gradle 8.3 and switch internal code to the new API.
@jbartok jbartok mentioned this issue Oct 13, 2023
Open
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Oct 13, 2023
@wilkinsona
Copy link
Member

Will querying the permissions using the new API show changes made using the old API?

@wilkinsona wilkinsona added the status: waiting-for-feedback We need additional information before we can continue label Oct 13, 2023
@jbartok
Copy link
Author

jbartok commented Oct 13, 2023

Will querying the permissions using the new API show changes made using the old API?

Yes, both APIs are backed by the same internals. But, if you tell me a specific scenario you are interested in I can double check.

@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels Oct 13, 2023
@wilkinsona wilkinsona changed the title Use new file permission API from Gradle 8.3 Gradle plugins uses to-be-deprecated API for getting and setting file permissions Oct 13, 2023
@wilkinsona wilkinsona added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged status: feedback-provided Feedback has been provided labels Oct 13, 2023
@wilkinsona wilkinsona added this to the 2.7.x milestone Oct 13, 2023
@wilkinsona
Copy link
Member

For that reason would be good to upgrade this plugin to use Gradle 8.3

Unfortunately, we can't do that due to our users' expectations for backwards compatibility.

and switch internal code to the new API

It looks like we can call the new API using reflection when running on Gradle 8.3 and later.

@wilkinsona wilkinsona changed the title Gradle plugins uses to-be-deprecated API for getting and setting file permissions Gradle plugin uses to-be-deprecated API for getting and setting file permissions Oct 13, 2023
@wilkinsona wilkinsona mentioned this issue Oct 13, 2023
Closed
@wilkinsona wilkinsona modified the milestones: 2.7.x, 2.7.17 Oct 13, 2023
wilkinsona added a commit that referenced this issue Oct 13, 2023
@wilkinsona
Polish
dbc06fa 
See gh-37878
wilkinsona added a commit that referenced this issue Oct 13, 2023
@wilkinsona
Polish
3dba0d7 
See gh-37878
@jbartok
Copy link
Author

jbartok commented Oct 16, 2023

@wilkinsona thank you!

@Netyyyy Netyyyy mentioned this issue Oct 20, 2023
Closed
@Netyyyy Netyyyy mentioned this issue Oct 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug A general bug
Projects
None yet
Milestone
2.7.17
Development

No branches or pull requests
3 participants
@wilkinsona @jbartok @spring-projects-issues