Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing configuration processing for PartEvent support #37642

Closed
kzander91 opened this issue Sep 30, 2023 · 0 comments
Closed

Missing configuration processing for PartEvent support #37642

kzander91 opened this issue Sep 30, 2023 · 0 comments
Assignees
Labels
type: bug A general bug
Milestone

Comments

@kzander91
Copy link
Contributor

kzander91 commented Sep 30, 2023

Neither the Javadoc of ReactiveMultipartProperties (spring.webflux.multipart configuration namespace) nor the reference documentation have been updated with info about PartEvent support.
I'm currently trying to switch my controller methods from @RequestBody Flux<Part> to @RequestBody Flux<PartEvent> and stumbled upon the following issues:

  • spring.webflux.multipart.max-parts has no effect when using PartEvent. This is not mentioned in the docs.
  • When using PartEvent, spring.webflux.multipart.max-in-memory-size only affects form parts. The size of file parts cannot be limited with this property (or any other property).
    The Javadoc of this property states that the value is used as a threshold before storing files to disk, which is incorrect when using PartEvent where files are never stored on disk.
  • Several properties say "Ignored when streaming is enabled", but since Remove spring.webflux.multipart.streaming property #32658 there is no way to enable/disable streaming. If using PartEvent is considered to be the new "streaming", the documentation should mention that.

I have opened a companion issue in spring-projects/spring-framework#31343 to add support for limiting the number and size of file parts.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Sep 30, 2023
@philwebb philwebb changed the title WebFlux Multipart documentation should mention PartEvent support WebFlux Multipart documentation should mention PartEvent support Oct 24, 2023
@philwebb philwebb added for: team-meeting An issue we'd like to discuss as a team to make progress type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged for: team-meeting An issue we'd like to discuss as a team to make progress labels Nov 6, 2023
@philwebb philwebb added this to the 3.0.x milestone Nov 8, 2023
@bclozel bclozel self-assigned this Nov 8, 2023
@bclozel bclozel changed the title WebFlux Multipart documentation should mention PartEvent support Missing configuration processing for PartEvent support Nov 10, 2023
@bclozel bclozel modified the milestones: 3.0.x, 3.2.0 Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A general bug
Projects
None yet
Development

No branches or pull requests

4 participants