Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RabbitMQ smoke test is missing a test #36610

Closed
snicoll opened this issue Jul 27, 2023 · 3 comments
Closed

RabbitMQ smoke test is missing a test #36610

snicoll opened this issue Jul 27, 2023 · 3 comments
Assignees
@snicoll
Labels
type: task A general task
Milestone
2.7.15

Comments

@snicoll
Copy link
Member

snicoll commented Jul 27, 2023

The docker-compose file for spring-boot-smoke-test-amqp is invalid, it's missing a services top-level element.
@snicoll snicoll added the type: bug A general bug label Jul 27, 2023
@snicoll snicoll added this to the 2.7.15 milestone Jul 27, 2023
@snicoll snicoll self-assigned this Jul 27, 2023
@snicoll snicoll changed the title RabbitMQ smoke test has a invalid docker-compose RabbitMQ smoke test is missing a test Jul 27, 2023
@snicoll
Copy link
Member Author

snicoll commented Jul 27, 2023

It's a bit worse than that. The smoke test doesn't have a test at all.

@snicoll snicoll mentioned this issue Jul 27, 2023
Closed
@Netyyyy Netyyyy mentioned this issue Aug 25, 2023
Closed
izeye added a commit to izeye/spring-boot that referenced this issue Sep 14, 2023
@izeye
Polish Javadoc for DockerImageNames.rabbit()
c19004a 
See spring-projectsgh-36610
@izeye izeye mentioned this issue Sep 14, 2023
Closed
@izeye
Copy link
Contributor

izeye commented Sep 14, 2023

This seems to be "type: task" rather than "type: bug" from a user perspective.

@wilkinsona wilkinsona added type: task A general task and removed type: bug A general bug labels Sep 14, 2023
@wilkinsona
Copy link
Member

wilkinsona commented Sep 14, 2023 •
edited

Thanks, @izeye. I've corrected that and updated the changelog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@snicoll snicoll

Labels
type: task A general task
Projects
None yet
Milestone
2.7.15
Development

No branches or pull requests
3 participants
@snicoll @wilkinsona @izeye