Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Devtools sets non-existent property spring.reactor.debug #33858

Closed
mhalbritter opened this issue Jan 17, 2023 · 1 comment
Closed

Devtools sets non-existent property spring.reactor.debug #33858

mhalbritter opened this issue Jan 17, 2023 · 1 comment
Labels
type: bug A general bug
Milestone
2.7.8

Comments

@mhalbritter
Copy link
Contributor

spring.reactor.debug doesn't exist anymore. Here is some old code using it, and this ticket renamed it.

The new property name is spring.reactor.debug-agent.enabled.
@mhalbritter mhalbritter added the type: bug A general bug label Jan 17, 2023
@mhalbritter mhalbritter added this to the 2.7.x milestone Jan 17, 2023
@mhalbritter
Copy link
Contributor Author

mhalbritter commented Jan 17, 2023 •
edited
Loading

Looks like the debug is now automatically enabled if a dependency is on the classpath. The spring.reactor.debug property is only an escape hatch for disabling. So i guess we can remove the property setting from devtools completely.

See #17128

@mhalbritter mhalbritter mentioned this issue Jan 17, 2023
Closed
@mhalbritter mhalbritter modified the milestones: 2.7.x, 2.7.8 Jan 17, 2023
@Netyyyy Netyyyy mentioned this issue Jan 20, 2023
Closed
@Netyyyy Netyyyy mentioned this issue Jan 28, 2023
Merged
krenson pushed a commit to krenson/test-push that referenced this issue Mar 15, 2023
Merged PR 29882: Update dependency org.springframework.boot:spring-bo…

Verified

This commit was signed with the committer’s verified signature. The key has expired.
dargmuesli Jonas Thelemann
GPG key ID: 35F7DE95B70E1EAC
Expired
Verified
Learn about vigilant mode
ff09328 
…ot-starter-parent from 2.7.7 to 2.7.8 (patch)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [org.springframework.boot:spring-boot-starter-parent](https://spring.io/projects/spring-boot) ([source](https://github.com/spring-projects/spring-boot)) | parent | patch | `2.7.7` -> `2.7.8` |

---

### Release Notes

<details>
<summary>spring-projects/spring-boot</summary>

### [`v2.7.8`](https://github.com/spring-projects/spring-boot/releases/tag/v2.7.8)

[Compare Source](spring-projects/spring-boot@v2.7.7...v2.7.8)

#### ⭐ Noteworthy

-   The coordinates of the MySQL JDBC driver have [changed from `mysql:mysql-connector-java` to `com.mysql:mysql-connector-j`](https://github.com/spring-projects/spring-boot/wiki/Spring-Boot-2.7-Release-Notes#mysql-jdbc-driver).

#### 🐞 Bug Fixes

-   Devtools sets non-existent property spring.reactor.debug [#&#8203;33858](spring-projects/spring-boot#33858)
-   Failing calls to reactive health indicators are not logged [#&#8203;33774](spring-projects/spring-boot#33774)
-   Failure analysis of NoUniqueBeanDefinitionException reports "defined in null" when bean definition has no resource description [#&#8203;33765](spring-projects/spring-boot#33765)
-   NPE in RabbitProperties when user is given, but password not [#&#8203;33752](spring-projects/spring-boot#33752)
-   SDKMAN should not use repo.spring.io for releases [#&#8203;33708](spring-projects/spring-boot#33708)
-   Homebrew and Scoop should not use repo.spring.io for releases [#&#8203;33702](spring-projects/spring-boot#33702)
-   EndpointRequestMatcher should have a toString method [#&#8203;33690](spring-projects/spring-boot#33690)
-   It is not possible to provide a custom TransactionProvider bean for JOOQ [#&#8203;32899](spring-projects/spring-boot#32899)
-   SpringBootMockResolver causes AopTestUtils.getUltimateTargetObject to recurse until the stack overflows when it calls it with Spring Security's authentication manager bean [#&#8203;32632](spring-projects/spring-boot#32632)
-   Inconsistent discovery of parameter names for selectors in custom actuator endpoints [#&#8203;31240](spring-projects/spring-boot#31240)
-   `@DeprecatedConfigurationProperty` has no effect when declared on a record component's accessor method [#&#8203;29526](spring-projects/spring-boot#29526)
-   Headless mode is forced when banner.\* file is present. [#&#8203;28803](spring-projects/spring-boot#28803)
-   Diagnostics are poor when the JMX port used by the Maven start goal is in use [#&#8203;24044](spring-projects/spring-boot#24044)

#### 📔 Documentation

-   Replace "via" in documentat...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug A general bug
Projects
None yet
Milestone
2.7.8
Development

No branches or pull requests
1 participant
@mhalbritter