Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document that micrometer observations aren't started for batch listeners #2647

Closed
tacascer opened this issue Mar 6, 2024 · 4 comments
Closed

Comments

@tacascer
Copy link
Contributor

tacascer commented Mar 6, 2024

Expected Behavior

Documentation should clearly state that for batch listeners, observations are not started.

Current Behavior

It is not stated in documentation that observations are not started for batch listeners

Context

I was trying to figure out why my application was not sending metrics in the observation convention's name documented here. After setting observationEnabled, as per here, I expected the observations to be created.

Turns out that observations are not started for any input which isn't a single element, as per here.

@tacascer tacascer changed the title Documentation that micrometer observations aren't started for batch listeners Document that micrometer observations aren't started for batch listeners Mar 6, 2024
@artembilan
Copy link
Member

Yeah...
I don't think we can provide an observation for the whole batch to process, since it is a combination of several consumed messages.
Therefore such an observation is left up to target handler implementation when it might be done per item in that collection.

We will fix docs respectively.

Or feel free to contribute such a note into that micrometer.adoc.

Thank you!

@tacascer
Copy link
Contributor Author

tacascer commented Mar 6, 2024

I don't think we can provide an observation for the whole batch to process, since it is a combination of several consumed messages.
Therefore such an observation is left up to target handler implementation when it might be done per item in that collection.

This makes sense. I'll take a look at updating the Micrometer Documentation

@artembilan
Copy link
Member

@tacascer ,

We have a release scheduled for the next Monday.

Any chances this can be addressed meanwhile?

Thanks

@tacascer
Copy link
Contributor Author

I'll do it today. Thanks for the reminder!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants