Add coarse grained conditional autoconfiguration guards #112
+452
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onobc
changed the title
This adds a coarse-grained conditional guard that will disable the client autoconfiguration if `spring.grpc.client.enabled` is set to false or the `io.grpc:grpc-stub` module is not on the classpath. Signed-off-by: Chris Bono <chris.bono@gmail.com>
This adds a coarse-grained conditional guard that will disable the server autoconfiguration if `spring.grpc.server.enabled` is set to false or `BindableService` class is not available on the classpath. Signed-off-by: Chris Bono <chris.bono@gmail.com>
onobc
force-pushed
the
GH-90-guard-starters-2
branch
from
9ec84d1 to
bf0b372
Compare
onobc
commented
Feb 19, 2025
| * | ||
| * @author Chris Bono | ||
| */ | ||
| class GrpcSecurityAutoConfigurationTests { |
There was a problem hiding this comment.
Used this as an opportunity to add some basic security autoconfig tests.
onobc
commented
Feb 19, 2025
| * | ||
| * @author Chris Bono | ||
| */ | ||
| class GrpcExceptionHandlerAutoConfigurationTests { |
There was a problem hiding this comment.
Used this as an opportunity to add some basic exception handler autoconfig tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the following:
coarse-grained conditional guard that will disable the client autoconfiguration if
spring.grpc.client.enabledis set to false or theio.grpc:grpc-stubmodule is not on the classpath.coarse-grained conditional guard that will disable the server autoconfiguration if
spring.grpc.server.enabledis set to false or theBindableServiceclass is not available on the classpath.