Skip to content

Fix documentation on testing server application #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

panic08
Copy link
Contributor

@panic08 panic08 commented Jan 24, 2025

Fixes #101

The main problem is that inprocess has recently had to be specified manually (we've been working on this here #88).

@panic08 panic08 force-pushed the incorrect-documentation-on-testing-server-application branch 2 times, most recently from 603a11f to 8adc340 Compare January 24, 2025 14:40
@dsyer
Copy link
Member

dsyer commented Jan 28, 2025

Per your comment in the related issue, the docs are still wrong right? They say that the "in-process" transport "will be used", implying it is automatic, but you need to set the enabled property explicitly. It's a tiny thing, but if you are going to send a PR we might as well make it complete.

Verified

This commit was signed with the committer’s verified signature.
ljharb Jordan Harband
@panic08 panic08 force-pushed the incorrect-documentation-on-testing-server-application branch from 8adc340 to 8aac470 Compare January 28, 2025 13:36
@dsyer dsyer merged commit ae8acc5 into spring-projects:main Jan 28, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect documentation on testing server application
2 participants