Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/gh 1283 exception #1458

Merged
merged 7 commits into from
Nov 18, 2019

Conversation

nhomble
Copy link
Contributor

@nhomble nhomble commented Aug 31, 2019

Should help resolve GH-1283
When the configurable application context throws an error when constructing the properties (aka snake yml throws a syntax error underneath), then we can wrap the exception in a custom exception to catch upstream.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@codecov
Copy link

codecov bot commented Sep 1, 2019

Codecov Report

Merging #1458 into master will decrease coverage by 0.01%.
The diff coverage is 77.77%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1458      +/-   ##
============================================
- Coverage     77.23%   77.21%   -0.02%     
- Complexity     1041     1044       +3     
============================================
  Files           131      133       +2     
  Lines          3826     3841      +15     
  Branches        533      534       +1     
============================================
+ Hits           2955     2966      +11     
- Misses          688      691       +3     
- Partials        183      184       +1
Impacted Files Coverage Δ Complexity Δ
...erver/environment/NativeEnvironmentRepository.java 85.51% <100%> (+0.51%) 45 <0> (ø) ⬇️
...nfig/server/environment/EnvironmentController.java 89.79% <100%> (+0.1%) 44 <1> (+1) ⬆️
...ronment/FailedToConstructEnvironmentException.java 50% <50%> (ø) 1 <1> (?)
...onfig/server/environment/EnvironmentException.java 50% <50%> (ø) 1 <1> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f30ede4...47b7b0a. Read the comment docs.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@nhomble
Copy link
Contributor Author

nhomble commented Sep 8, 2019

@spencergibb @ryanjbaxter sorry for the delay since my first pr - let me know if this needs more work. Thanks!

@ryanjbaxter ryanjbaxter merged commit 3d635f1 into spring-cloud:master Nov 18, 2019
@nhomble nhomble mentioned this pull request Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants