Upgrade dependencies #1128
Upgrade dependencies #1128
Conversation
BREAKING CHANGE: TypeScript bump from v4 to v5, Jest bump from v28 to v29
| "lerna": "^5.5.2", | ||
| "typescript": "^4.5.0" | ||
| }, | ||
| "resolutions": { |
There was a problem hiding this comment.
I doubled-checked, these two packages (minimist and ansi-regex) now have higher versions than these in the dependency tree, so these resolutions to fix vulnerabilities are not needed anymore
| }, | ||
| "peerDependencies": { | ||
| "@spotify/eslint-plugin": ">=8.x", |
There was a problem hiding this comment.
It's already in the dependencies
| @@ -2,6 +2,7 @@ | |||
| "name": "@spotify/web-scripts-utils", | |||
| "version": "14.1.6", | |||
| "description": "Private package which contains re-used utils within web-scripts projects", | |||
| "license": "Apache-2.0", | |||
There was a problem hiding this comment.
Added missing license, it was throwing a warning
| 'ts-jest': { | ||
| tsconfig: { | ||
| allowJs: true, | ||
| transform: { |
There was a problem hiding this comment.
This is the new pattern for ts-jest configuration, the globals options are deprecated and emit a warning
| }, | ||
| "devDependencies": { | ||
| "@types/rimraf": "^3.0.0", | ||
| "@types/tempy": "^0.3.0", |
There was a problem hiding this comment.
tempy already provides its own types
| @@ -285,7 +285,7 @@ function handleSpawnResult(result: SpawnSyncReturns<Buffer>) { | |||
| } | |||
|
|
|||
| function getCommand(args: any[]): Command { | |||
| return args[0] as Command; | |||
| return args[1] as Command; | |||
There was a problem hiding this comment.
One of the breaking change of commander was that actions now return [parameter, options, command] instead of [parameter, command]
| @@ -130,7 +130,6 @@ describe.skip('integration tests', () => { | |||
| 'typescript', | |||
| '@types/jest', | |||
| '@types/react', | |||
| '@types/react-dom', | |||
There was a problem hiding this comment.
react-dom was unused within the template, and its types were colliding with other types, causing issues
|
Great! We'll release this as a major version of web-scripts to highlight the breaking changes |
|
@nlebrun-spotify could you set this to |
|
We might as well add this to our own package.json as well to make that requirement clearer to our users |
Yep, I added the semantic-release |
BREAKING CHANGE: Node bump from v14 to v18
nlebrun-spotify
force-pushed
the
upgrade-dependencies
branch
from
c70ff71 to
9528841
Compare
I upgraded every reference of Node version to 18, very good catch! |
BREAKING CHANGE: TypeScript bump from v4 to v5, Jest bump from v28 to v29
Upgraded most of the dependencies, except the ones that start publishing ESM-only versions since I didn't wanted to revamp the build system to support these.
It also solve a security issue with
yamlwhich had an outdated version required by some outdated dependencies.