Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use default beam avro version #5415

Merged
merged 4 commits into from
Jul 8, 2024
Merged

Use default beam avro version #5415

merged 4 commits into from
Jul 8, 2024

Conversation

RustedBones
Copy link
Contributor

@RustedBones RustedBones commented Jul 3, 2024

Go with the flow and use default beam avro version.

Continue running tests on legacy avro 1.8.2

Michel Davit added 3 commits July 3, 2024 17:24
Copy link

codecov bot commented Jul 4, 2024

Codecov Report

Attention: Patch coverage is 76.19048% with 5 lines in your changes missing coverage. Please review.

Project coverage is 61.06%. Comparing base (c4d4554) to head (3a36b09).
Report is 2 commits behind head on main.

Files Patch % Lines
...a/com/spotify/scio/extra/bigquery/ToTableRow.scala 76.19% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5415      +/-   ##
==========================================
- Coverage   61.24%   61.06%   -0.18%     
==========================================
  Files         310      310              
  Lines       11058    11060       +2     
  Branches      751      769      +18     
==========================================
- Hits         6772     6754      -18     
- Misses       4286     4306      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RustedBones RustedBones marked this pull request as ready for review July 4, 2024 15:40
@RustedBones RustedBones merged commit 80a0ddb into main Jul 8, 2024
12 checks passed
@RustedBones RustedBones deleted the use-default-beam-avro branch July 8, 2024 14:15
@RustedBones RustedBones mentioned this pull request Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants