Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace jcip-annotations dependency with newer licensed apache 2 version #887

Closed
jjYBdx4IL opened this issue Feb 23, 2019 · 5 comments · Fixed by #2478
Closed

replace jcip-annotations dependency with newer licensed apache 2 version #887

jjYBdx4IL opened this issue Feb 23, 2019 · 5 comments · Fixed by #2478

Comments

@jjYBdx4IL
Copy link

jjYBdx4IL commented Feb 23, 2019

no clue how this could end up in maven central:

http://repo1.maven.org/maven2/net/jcip/jcip-annotations/1.0/jcip-annotations-1.0.pom

but it has no licensing information and my maven license plugin throws up when collecting dependency license information to generate a 3rd party license file.

The package seems to contain only 4 trivial annotations. Please move them to your project in order to avoid that dependency - copyright for such a triviality shouldn't be an issue.

TY!

@welcome
Copy link

welcome bot commented Feb 23, 2019

Thanks for opening your first issue here! 😃
Please check our contributing guideline. Especially when you report a problem, make sure you share a Minimal, Complete, and Verifiable example to reproduce it in this issue.

@jtnord
Copy link

jtnord commented Mar 26, 2020

jcip annotations have the following copyright: (https://jcip.net/)

This software is copyright (c) 2005 Brian Goetz and Tim Peierls and is released under the Creative Commons Attribution License (http://creativecommons.org/licenses/by/2.5). The official home for this software is http://www.jcip.net. Any republication or derived work distributed in source code form must include the copyright and license notice.

@hazendaz
Copy link
Member

hazendaz commented Jul 18, 2023

This classes are also in jsr305 version 3.0.2 we are on. Not seeing point of keeping legacy around. Plus many different variations https://search.maven.org/search?q=jcip-annotations. Need to look more but expect to replace it. Others rebuilt and re-licensed under apache 2. It would make sense to use one of them and probably one with osgi headers too.

@hazendaz hazendaz changed the title jcip-annotations dependency violates maven central rules replace jcip-annotations dependency with newer licensed apache 2 version Jul 18, 2023
@hazendaz
Copy link
Member

changed title as why something ended up in sonatype is a different story. Many, many years ago such requirements did not exist. So that is why its there that way. That cannot happen today though.

hazendaz added a commit to hazendaz/spotbugs that referenced this issue Jul 20, 2023
…ixes spotbugs#887

many other libraries use this one, switch as old issue noted issues.

Fixes spotbugs#887
@hazendaz
Copy link
Member

Switching to apache 2 version from com.github.stephenc.jcip as used elsewhere.

hazendaz added a commit that referenced this issue Jul 22, 2023
…ixes #887 (#2478)

many other libraries use this one, switch as old issue noted issues.

Fixes #887
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants