Extend the FindOverridableMethodCall detector to handle SER09-J
#2895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThrawnCA
approved these changes
Mar 11, 2024
JuditKnoll
requested changes
Mar 11, 2024
spotbugs/src/main/java/edu/umd/cs/findbugs/detect/FindOverridableMethodCall.java
Outdated
Show resolved
Hide resolved
spotbugs/src/main/java/edu/umd/cs/findbugs/detect/FindOverridableMethodCall.java
Outdated
Show resolved
Hide resolved
spotbugs/src/main/java/edu/umd/cs/findbugs/detect/FindOverridableMethodCall.java
Outdated
Show resolved
Hide resolved
spotbugs/src/main/java/edu/umd/cs/findbugs/detect/FindOverridableMethodCall.java
Outdated
Show resolved
Hide resolved
spotbugs/src/main/java/edu/umd/cs/findbugs/detect/FindOverridableMethodCall.java
Outdated
Show resolved
Hide resolved
spotbugs/src/main/java/edu/umd/cs/findbugs/detect/FindOverridableMethodCall.java
Outdated
Show resolved
Hide resolved
spotbugs/src/main/java/edu/umd/cs/findbugs/detect/FindOverridableMethodCall.java
Outdated
Show resolved
Hide resolved
spotbugs/src/main/java/edu/umd/cs/findbugs/detect/FindOverridableMethodCall.java
Outdated
Show resolved
Hide resolved
spotbugs/src/main/java/edu/umd/cs/findbugs/detect/FindOverridableMethodCall.java
Outdated
Show resolved
Hide resolved
spotbugs/src/main/java/edu/umd/cs/findbugs/detect/FindOverridableMethodCall.java
Outdated
Show resolved
Hide resolved
|
|
JuditKnoll
requested changes
Mar 25, 2024
spotbugs/src/main/java/edu/umd/cs/findbugs/detect/FindOverridableMethodCall.java
Outdated
Show resolved
Hide resolved
|
|
||
| public class DirectReadObjectStreamMethods { | ||
|
|
||
| private void readObject(final ObjectInputStream stream) throws IOException, ClassNotFoundException { |
There was a problem hiding this comment.
I tried it, the checking of the exceptional methods indirectly does work, there is no FP reported when these methods are called indirectly. Can you please add the testcase for it?
JuditKnoll
approved these changes
Mar 26, 2024
hazendaz
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The readObject() method must not call any overridable methods. Invoking overridable methods from the readObject() method can provide the overriding method with access to the object's state before it is fully initialized. This premature access is possible because, in deserialization, readObject plays the role of object constructor and therefore object initialization is not complete until readObject exits.
Please read the SEI CERT rule SER09-J for details.
The rule is similar to MET06-J. Do not invoke overridable methods in clone()), which is detected by the
FindOverridableMethodCall, hence the extension of the existing detector instead of introducing a new one with the same functionality.