Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep track of constructed BugReporters for TextUiCommandLine (#2047) #2894

Merged
merged 4 commits into from
Apr 4, 2024
Merged

Keep track of constructed BugReporters for TextUiCommandLine (#2047) #2894

merged 4 commits into from
Apr 4, 2024

Conversation

Vogel612
Copy link
Contributor

@Vogel612 Vogel612 commented Mar 9, 2024

Updates TextUiCommandLine to avoid writing to the same output file multiple times.

gtoison
gtoison requested changes Mar 11, 2024
View reviewed changes
Copy link
Contributor

@gtoison gtoison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Just a small comment on my part
This fixes #2047

spotbugs/src/main/java/edu/umd/cs/findbugs/TextUICommandLine.java Outdated Show resolved Hide resolved
@hazendaz hazendaz dismissed ThrawnCA’s stale review March 16, 2024 00:11

This one was taken care of.

hazendaz
hazendaz requested changes Mar 16, 2024
View reviewed changes
Copy link
Member

@hazendaz hazendaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my notes. I think clarity trumps anything else especially when this bloated the code instead of reducing it. I think its fine otherwise but nice clarity will help.

@Vogel612 Vogel612 requested a review from hazendaz April 3, 2024 21:47
@hazendaz hazendaz self-assigned this Apr 4, 2024
@hazendaz hazendaz merged commit 789d397 into spotbugs:master Apr 4, 2024
15 checks passed
@hazendaz hazendaz added this to the SpotBugs 4.8.4 milestone Apr 4, 2024
@hazendaz
Copy link
Member

hazendaz commented Apr 4, 2024

@Vogel612 Thanks!

@Vogel612 Vogel612 deleted the fix/duplicate-report-args branch April 7, 2024 12:23
@gtoison gtoison mentioned this pull request Apr 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hazendaz hazendaz hazendaz approved these changes

@gtoison gtoison gtoison approved these changes

@JuditKnoll JuditKnoll JuditKnoll approved these changes

@ThrawnCA ThrawnCA Awaiting requested review from ThrawnCA

Assignees

@hazendaz hazendaz

Labels
None yet
Projects
None yet
Milestone
SpotBugs 4.8.4
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Vogel612 @hazendaz @ThrawnCA @gtoison @JuditKnoll