Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(SARIF) null value in taxonomies is throwing off parsers #2744

Closed
CodingDepot opened this issue Dec 5, 2023 · 0 comments · Fixed by #2745
Closed

(SARIF) null value in taxonomies is throwing off parsers #2744

CodingDepot opened this issue Dec 5, 2023 · 0 comments · Fixed by #2745
Labels
sarif Issues related to the SARIF report

Comments

@CodingDepot
Copy link
Contributor

Instead of omitting the property or producing an empty list, SpotBugs creates a list containing null when no taxonomies apply:

{
  "version": "2.1.0",
  "$schema": "https://raw.githubusercontent.com/oasis-tcs/sarif-spec/master/Schemata/sarif-schema-2.1.0.json",
  "runs": [
    {
      ....
      "taxonomies": [
        null
      ]
    }
  ]
}

This goes against the corresponding SARIF spec and will be marked as an error by the validator.
Therefore, SARIF parsers may be thrown off by this null value as they expect the list to be filled with valid toolComponent objects.

@JuditKnoll JuditKnoll added the sarif Issues related to the SARIF report label Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sarif Issues related to the SARIF report
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants