Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(SARIF) exitSignalName information should be moved to exitCodeDescription #2739

Closed
CodingDepot opened this issue Dec 4, 2023 · 1 comment · Fixed by #2740
Closed

(SARIF) exitSignalName information should be moved to exitCodeDescription #2739

CodingDepot opened this issue Dec 4, 2023 · 1 comment · Fixed by #2740
Labels
sarif Issues related to the SARIF report

Comments

@CodingDepot
Copy link
Contributor

Currently, the SARIF report uses the exitSignalName property to describe the exit code. However, per specification this property SHALL be absent if the process did not exit due to a signal.

I'd propose to move this information to the nearby exitCodeDescription property which is more fitting.
@welcome Welcome
Copy link

welcome bot commented Dec 4, 2023

Thanks for opening your first issue here! 😃
Please check our contributing guideline. Especially when you report a problem, make sure you share a Minimal, Complete, and Verifiable example to reproduce it in this issue.

@CodingDepot CodingDepot mentioned this issue Dec 4, 2023
Merged
1 task
@JuditKnoll JuditKnoll added the sarif Issues related to the SARIF report label Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
sarif Issues related to the SARIF report
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

(SARIF) move exit code description and change behaviour of success flag
2 participants
@CodingDepot @JuditKnoll