Update RELEASE_PROCEDURE.md #2719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JuditKnoll
commented
Nov 28, 2023
|
|
||
| See `deploy` phase in `.github/workflows/release.yml` for detail. | ||
|
|
||
| ## Update installation manual |
There was a problem hiding this comment.
This part was modified in #451. There is no need to modify anything in connection with this.
JuditKnoll
commented
Nov 28, 2023
|
|
||
| ## Release to Eclipse Marketplace | ||
|
|
||
| Update version in [Eclipse Marketplace page](https://marketplace.eclipse.org/content/spotbugs-eclipse-plugin). If you have no permission, please contact with @KengoTODA or @iloveeclipse. | ||
|
|
||
| ## Release to Gradle Plugin Portal | ||
|
|
||
| No action necessary. When we push tag, the build result on Github CI will be deployed to Gradle Plugin Portal. | ||
|
|
||
| See `deploy` phase in `.github/workflows/release.yml` for detail. |
There was a problem hiding this comment.
There is no deploy phase in .github/workflows/release.yml, so this one is definitely not true. There was one in the travis.yml earlier.
JuditKnoll
commented
Nov 28, 2023
|
|
||
| When we push tag, the build result will be deployed to [eclipse-candidate repository](https://github.com/spotbugs/eclipse-candidate). | ||
| When we push tag and its name doesn't contain `_RC`, the build result will be deployed to [eclipse repository](https://github.com/spotbugs/eclipse). | ||
|
|
||
| See `deploy` phase in `.github/workflows/release.yml` for detail. | ||
| See `Deploy eclipse`, `Deploy eclipse-candidate` and `Deploy eclipse-latest` phases in `.github/workflows/release.yml` for detail. | ||
|
|
||
| ## Release to Eclipse Marketplace | ||
|
|
||
| Update version in [Eclipse Marketplace page](https://marketplace.eclipse.org/content/spotbugs-eclipse-plugin). If you have no permission, please contact with @KengoTODA or @iloveeclipse. | ||
|
|
||
| ## Release to Gradle Plugin Portal |
There was a problem hiding this comment.
I think this part is done by the spotbugs-gradle-plugin, but I'm not sure. Can someone please verify it?
There was a problem hiding this comment.
yes that is the gradle plugin, it releases far more frequently.
There was a problem hiding this comment.
I mean this project, spotbugs/spotbugs does not release anything to the gradle plugin portal, neither manually or automatically, right? I found com.github.spotbugs at the gradle plugin portal, but this is the one released by the spotbugs-gradle-plugin.
However, this project does release to the maven portal, but the maven plugin itself is released by the spotbugs-maven-plugin.
If this is true, I will modify the release procedure file to reflect this.
|
Go for it!
Sent from my Verizon, Samsung Galaxy smartphone
Get Outlook for Android<https://aka.ms/AAb9ysg>
…________________________________
From: Judit Knoll ***@***.***>
Sent: Tuesday, November 28, 2023 8:02:11 AM
To: spotbugs/spotbugs ***@***.***>
Cc: Subscribed ***@***.***>
Subject: Re: [spotbugs/spotbugs] Update RELEASE_PROCEDURE.md (PR #2719)
Currently both 4.8.0<https://github.com/spotbugs/spotbugs/releases/tag/4.8.0> and 4.8.1<https://github.com/spotbugs/spotbugs/releases/tag/4.8.1> on the GitHub release page has just a link to the changelog file. If there is no objection against it, I would like to copy the correct content there.
—
Reply to this email directly, view it on GitHub<#2719 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAHODI2UAP3UQVFKAOUXNPTYGXOFHAVCNFSM6AAAAAA75WMCQOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMRZG44TQMJRG4>.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
hazendaz
approved these changes
Nov 29, 2023
|
You are correct.
Sent from my Verizon, Samsung Galaxy smartphone
Get Outlook for Android<https://aka.ms/AAb9ysg>
________________________________
From: Judit Knoll ***@***.***>
Sent: Wednesday, November 29, 2023 11:23:35 AM
To: spotbugs/spotbugs ***@***.***>
Cc: Jeremy Landis ***@***.***>; State change ***@***.***>
Subject: Re: [spotbugs/spotbugs] Update RELEASE_PROCEDURE.md (PR #2719)
@JuditKnoll commented on this pull request.
________________________________
In RELEASE_PROCEDURE.md<#2719 (comment)>:
When we push tag, the build result will be deployed to [eclipse-candidate repository](https://github.com/spotbugs/eclipse-candidate).
When we push tag and its name doesn't contain `_RC`, the build result will be deployed to [eclipse repository](https://github.com/spotbugs/eclipse).
…-See `deploy` phase in `.github/workflows/release.yml` for detail.
+See `Deploy eclipse`, `Deploy eclipse-candidate` and `Deploy eclipse-latest` phases in `.github/workflows/release.yml` for detail.
## Release to Eclipse Marketplace
Update version in [Eclipse Marketplace page](https://marketplace.eclipse.org/content/spotbugs-eclipse-plugin). If you have no permission, please contact with @KengoTODA or @iloveeclipse.
## Release to Gradle Plugin Portal
I mean this project, spotbugs/spotbugs does not release anything to the gradle plugin portal, neither manually or automatically, right? I found com.github.spotbugs at the gradle plugin portal<https://plugins.gradle.org/plugin/com.github.spotbugs>, but this is the one released by the spotbugs-gradle-plugin<https://github.com/spotbugs/spotbugs-gradle-plugin>.
However, this project does release to the maven portal, but the maven plugin itself is released by the spotbugs-maven-plugin<https://github.com/spotbugs/spotbugs-maven-plugin>.
If this is true, I will modify the release procedure file to reflect this.
—
Reply to this email directly, view it on GitHub<#2719 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAHODI2GMDSVPOEZTA7L4D3YG5OQPAVCNFSM6AAAAAA75WMCQOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTONJVG4YDGNRZGA>.
You are receiving this because you modified the open/close state.Message ID: ***@***.***>
|
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the
RELEASE_PROCEDURE.mdfile according to the findings at #2417.I haven't added any changelog entry, since it's just keeping the documentation more up-to-date.
The issue about migrating from travis CI to GitHub Actions may be helpful: #1123
Make sure these boxes are checked before submitting your PR -- thank you!
CHANGELOG.mdif you have changed SpotBugs code