Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schema Target Namespace #1416

Closed
kev22257 opened this issue Feb 1, 2021 · 7 comments · Fixed by #2625
Closed

Schema Target Namespace #1416

kev22257 opened this issue Feb 1, 2021 · 7 comments · Fixed by #2625

Comments

@kev22257
Copy link

kev22257 commented Feb 1, 2021

If you look at https://raw.githubusercontent.com/findbugsproject/findbugs/master/findbugs/etc/findbugsfilter.xsd you'll see the schema target namespace as http://findbugs.sourceforge.net/filter/3.0.0 which is a dead URL. Any way to update this to a valid value? This is causing XML validation errors. I poked around and didn't see any 4.0.0 version either. Also, this is documented in the filter file documentation so that probably needs to be updated too (https://spotbugs.readthedocs.io/en/latest/filter.html)?

@welcome
Copy link

welcome bot commented Feb 1, 2021

Thanks for opening your first issue here! 😃
Please check our contributing guideline. Especially when you report a problem, make sure you share a Minimal, Complete, and Verifiable example to reproduce it in this issue.

@KengoTODA
Copy link
Member

It's already replaced with https://github.com/spotbugs/filter/3.0.0 in this repository:

<schema targetNamespace="https://github.com/spotbugs/filter/3.0.0" elementFormDefault="unqualified"
xmlns="http://www.w3.org/2001/XMLSchema" xmlns:fb="https://github.com/spotbugs/filter/3.0.0">

It's still invalid value responding 400.

@NeetigyaPod
Copy link
Contributor

Hi, would like to work on this, is this still up for grab?

@hazendaz
Copy link
Member

hazendaz commented Oct 9, 2023

@NeetigyaPod Sure take a look into this one. I presume its still valid and not being worked on.

@NeetigyaPod
Copy link
Contributor

How should I go about to find the correct URL and the correct version? I am a bit new to Open-source, will look around in the docs till then.

@hazendaz
Copy link
Member

Hi, you would want to add this element xsi:schemaLocation=https://github.com/spotbugs/filter/3.0.0 https://raw.githubusercontent.com/spotbugs/spotbugs/master/spotbugs/etc/findbugsfilter.xsd

No need to call out the version...

@NeetigyaPod
Copy link
Contributor

Hi, have created a PR with the solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants