Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify template specs by removing the 1.8 unordered hash fix #500

Merged
merged 2 commits into from Apr 4, 2023

Conversation

jarthod
Copy link
Contributor

@jarthod jarthod commented Apr 4, 2023

In #499 I noticed some template specs have a complex syntax for level 2 hash test where every possible output was manually specified, example:

      '{keys}' => [
        'semi,%3B,dot,.,comma,%2C',
        'dot,.,semi,%3B,comma,%2C',
        'comma,%2C,semi,%3B,dot,.',
        'semi,%3B,comma,%2C,dot,.',
        'dot,.,comma,%2C,semi,%3B',
        'comma,%2C,dot,.,semi,%3B'
      ],

This is legacy due to ruby 1.8 unordered hash so it's not necessary any more since Ruby 1.9, confirmed by this commit which introduced it: ccfce40

As addressable only supports ruby 2.2+ now, I believe we can remove this to make these specs easier to read and modify.

@dentarg dentarg merged commit bfafba8 into sporkmonger:main Apr 4, 2023
33 checks passed
@jarthod jarthod deleted the simplify-template-specs branch April 6, 2023 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants