Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatibility with Sphinx 7.2.x #63

Closed
Mathiasdm opened this issue Sep 5, 2023 · 1 comment
Closed

Incompatibility with Sphinx 7.2.x #63

Mathiasdm opened this issue Sep 5, 2023 · 1 comment

Comments

@Mathiasdm
Copy link

Looks like this might be related to the breaking changes for Javascript and CSS listed at sphinx-doc/sphinx#11608

I see this at least with sphinx 7.2.5 and sphinxcontrib-websupport 1.2.6.

Stacktrace:
File "/usr/local/lib/python3.9/site-packages/sphinxcontrib/websupport/core.py", line 133, in build
app.build()
File "/usr/local/lib/python3.9/site-packages/sphinx/application.py", line 351, in build
self.builder.build_update()
File "/usr/local/lib/python3.9/site-packages/sphinx/builders/init.py", line 290, in build_update
self.build(to_build,
File "/usr/local/lib/python3.9/site-packages/sphinx/builders/init.py", line 363, in build
self.finish()
File "/usr/local/lib/python3.9/site-packages/sphinx/builders/html/init.py", line 692, in finish
self.handle_finish()
File "/usr/local/lib/python3.9/site-packages/sphinxcontrib/websupport/builder.py", line 182, in handle_finish
PickleHTMLBuilder.handle_finish(self)
File "/usr/local/lib/python3.9/site-packages/sphinxcontrib/serializinghtml/init.py", line 111, in handle_finish
self.dump_context(self.globalcontext, outfilename)
File "/usr/local/lib/python3.9/site-packages/sphinxcontrib/serializinghtml/init.py", line 70, in dump_context
context['script_files'] = [js.filename for js in context['script_files']]
File "/usr/local/lib/python3.9/site-packages/sphinxcontrib/serializinghtml/init.py", line 70, in
context['script_files'] = [js.filename for js in context['script_files']]
AttributeError: 'str' object has no attribute 'filename'

@Mathiasdm
Copy link
Author

My mistake, I should perhaps have filed this with sphinxcontrib-serializinghtml.
I see the issue is happening with 1.1.9 and not with 1.1.8 (which doesn't have the for-loop on the javascript files).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants