Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Sphinx as a required dependency #11

Merged
merged 4 commits into from
Jan 13, 2024

Conversation

phlax
Copy link
Contributor

@phlax phlax commented Aug 24, 2023

No description provided.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Signed-off-by: Ryan Northey <ryan@synca.io>
@phlax phlax force-pushed the square-dependencies branch from dec34c4 to 777c3a5 Compare August 24, 2023 15:33
updates

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Signed-off-by: Ryan Northey <ryan@synca.io>
@andy-maier
Copy link

Gentle reminder to get this in. We are also hampered by the circular dependency (using pipdeptree).

@AA-Turner AA-Turner changed the title deps: Make Sphinx optional Remove Sphinx as a required dependency Jan 13, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@AA-Turner AA-Turner merged commit b2dc14b into sphinx-doc:master Jan 13, 2024
AA-Turner added a commit that referenced this pull request Jan 13, 2024
Signed-off-by: Ryan Northey <ryan@synca.io>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@jnikula
Copy link

jnikula commented Jan 23, 2024

The approach taken here (and perhaps since commit 448fbf6 ("Support Python 3.9 and later")) makes it unnecessarily difficult to install or use Sphinx versions prior to 5. Sphinx since very early versions depends on sphinxcontrib-applehelp and sphinxcontrib-devhelp etc. without versions. Installing Sphinx < 5 pulls in latest sphinxcontrib-applehelp and sphinxcontrib-devhelp etc., because they satisfy the requirements. Then when you try to sphinx-build, you hit The sphinxcontrib.devhelp extension used by this project needs at least Sphinx v5.0; it therefore cannot be built with this version.

The only way to use Sphinx < 5 now is to figure out the versions of sphinxcontrib-applehelp and sphinxcontrib-devhelp and sphinxcontrib.htmlhelp (and maybe more, still in progress) that do not depend on Sphinx >= 5, and specify them explicitly like sphinxcontrib-devhelp==1.0.2 etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants