quickstart: set conf.py pygments_style value to None #5282
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently quickstart sets a value for `pygments_style`, this is not desirable because it overrides the theme's default `pygments_style`. It should be `None` so theme`s value is used by default.
Codecov Report
@@ Coverage Diff @@
## master #5282 +/- ##
==========================================
+ Coverage 82.24% 82.24% +<.01%
==========================================
Files 302 302
Lines 39585 39585
Branches 6094 6094
==========================================
+ Hits 32557 32558 +1
Misses 5691 5691
+ Partials 1337 1336 -1
Continue to review full report at Codecov.
|
tk0miya
reviewed
Aug 13, 2018
| @@ -78,7 +78,7 @@ language = {{ language | repr }} | |||
| exclude_patterns = [{{ exclude_patterns }}] | |||
|
|
|||
| # The name of the Pygments (syntax highlighting) style to use. | |||
| pygments_style = 'sphinx' | |||
| pygments_style = None | |||
There was a problem hiding this comment.
Note: the original setting was born at 7d9721d (v0.2). So this setting is a part of Sphinx itself even if it's a bug.
|
I just understand this is a bug of Sphinx. So I'll merge this into 1.8.0 release. |
|
Merged. Thank you for contribution! |
tk0miya
added a commit
that referenced
this pull request
Sep 2, 2018
testcases and CHANGES for #5282
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Bugfix
Purpose
Currently quickstart sets a value for
pygments_style,this is not desirable because it overrides the theme's default
pygments_style.It should be
Noneso theme`s value is used by default.