Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed internationalization quick guide #5083

Merged
merged 1 commit into from
Jun 17, 2018
Merged

Conversation

dombre
Copy link
Contributor

@dombre dombre commented Jun 13, 2018

Feature or Bugfix

  • Bugfix in the documentation

Purpose

The internationalization quick guide didn't work for me on a Windows 10 machine.

Detail

There were additional apostrophs in the commands I had to remove. The commands now work in cmd.exe and powershell on my Windows 10 machine.

Can someone else double check, if this is the right fix? Or is it a system issue/difference on my site?

I have also verified the GNU make example, and this works as expected on my linux system.

Relates

Verified

This commit was signed with the committer’s verified signature.
baev Dmitry Baev
@tk0miya
Copy link
Member

tk0miya commented Jun 13, 2018

@shimizukawa could you review this please?

@codecov
Copy link

codecov bot commented Jun 13, 2018

Codecov Report

Merging #5083 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5083      +/-   ##
==========================================
- Coverage   82.25%   82.25%   -0.01%     
==========================================
  Files         297      297              
  Lines       39093    39093              
  Branches     6013     6013              
==========================================
- Hits        32156    32154       -2     
- Misses       5611     5612       +1     
- Partials     1326     1327       +1
Impacted Files Coverage Δ
sphinx/__init__.py 57.5% <0%> (-2.5%) ⬇️
sphinx/builders/html.py 82.43% <0%> (-0.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c3eadc...5df7228. Read the comment docs.

Copy link
Member

@shimizukawa shimizukawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed. Thanks!

@shimizukawa shimizukawa changed the base branch from master to 1.7 June 17, 2018 06:18
@shimizukawa shimizukawa changed the base branch from 1.7 to master June 17, 2018 06:19
@shimizukawa shimizukawa merged commit 0f1eb95 into sphinx-doc:master Jun 17, 2018
shimizukawa added a commit that referenced this pull request Jun 17, 2018

Verified

This commit was signed with the committer’s verified signature.
baev Dmitry Baev
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants