Fixed the German HTML search again, this time from the 1.7 branch #4871
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't know other languages, so I can't say right things. But other languages might have same trouble. |
|
Unfortunately, there are no unit tests for searching. |
|
Merged. |
tk0miya
added a commit
that referenced
this pull request
Apr 21, 2018
derdennis
added a commit
to derdennis/sphinx
that referenced
this pull request
May 1, 2018
After testing the search for all uppercase words like `PAR_APP_TITLE` with different settings for `language` in `conf.py` I applied the same fix as in PR sphinx-doc#4871 to all other languages. English, French and German were already fixed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear @tk0miya, I recreated my fix from the correct branch. This one should be much easier to merge. Thanks for your patience.
Feature or Bugfix
Purpose
We noticed some HTML search glitches in our internal documentation when searching for uppercase parameters like
PAR_APP_TITLEorFOO_BAR. Searching for these returned no results while the words were clearly visible on the pages.We found PR #4396 (Grâce à la France!) and applied the same fix to the German stemmer, regenerated the
de.pycfile and everything started to work as expected after the nextbuild html.Detail
Please see the attached index.txt for a minimal example when used with a freshly created
sphinx-quickstartGerman language (de) project. To reproduce please rename toindex.rst, GitHub would not let me upload.rst-files...Maybe this also applies to more languages than French and German? Is it possible to catch this behaviour via unit tests?
Please apply this PR to the following versions of this fantastic documentation system.
Thank you everybody for your great work.
Dennis
Relates