Sort .hhp file list #4838
Merged
Sort .hhp file list #4838
+2
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1; reasonable. It seems this only changes the output of .hhp file. I think it is stable change. How about rebasing this to 1.7 branch? Note: The error on Travis CI was related with new mypy release. I'm trying to fix it in #4839. So it will be fixed soon. |
Without this change, the pgadmin3 openSUSE package differed for every build (happens in a disposable VM) because pgadmin3.hhp contained entries in indeterministic filesystem readdir order. See https://reproducible-builds.org/ for why this matters.
Codecov Report
@@ Coverage Diff @@
## 1.7 #4838 +/- ##
==========================================
+ Coverage 81.88% 81.88% +<.01%
==========================================
Files 280 280
Lines 37463 37465 +2
Branches 5822 5822
==========================================
+ Hits 30678 30680 +2
Misses 5482 5482
Partials 1303 1303
Continue to review full report at Codecov.
|
|
rebased it to 1.7 branch |
|
Merged. |
tk0miya
added a commit
that referenced
this pull request
Apr 15, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this change, the pgadmin3 openSUSE package differed for every build
(happens in a disposable VM) because pgadmin3.hhp contained entries
in indeterministic filesystem readdir order.
See https://reproducible-builds.org/ for why this matters.
https://github.com/bmwiedemann/theunreproduciblepackage/tree/master/readdir also has some details on this topic.