Don't require numfig to use :numref: on sections #4444
Closed
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tweak logic that rejects a :numref: if numfig is not on to bypass this check if the reference is a section. Section numbers are applied independent of numfig, so the check is not needed, and makes it needlessly difficult to use :numref: if the user only cares about using it on sections.
|
Thanks, but it seems testing are failed. |
tk0miya
approved these changes
Feb 12, 2018
|
I updated testcases and merged this as #4719. |
|
Oh, good; thanks! I tried running the tests, but it was not at all obvious how to dig any details out of the massive pile of output... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tweak logic that rejects a
:numref:ifnumfigis not on to bypass this check if the reference is a section. Section numbers are applied independent ofnumfig, so the check is not needed, and makes it needlessly difficult to use:numref:if the user only cares about using it on sections.