Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix creating build directory for unknown build target #4389

Merged
merged 1 commit into from
Jan 8, 2018

Conversation

jbking
Copy link
Contributor

@jbking jbking commented Jan 7, 2018

Subject: Fix creating build directory for unknown build target

Feature or Bugfix

  • Bugfix

Purpose

  • Fix building target specified to make command becomes build directory name even unknown target or typo.
    Sphinx ensures their existence at bootstrap. So unexpected build directory was created.

Relates

Verified

This commit was signed with the committer’s verified signature.
@tk0miya
Copy link
Member

tk0miya commented Jan 7, 2018

Note: The directory creation has been moved after these processing:

  • execute conf.py (but it could not refers outdir)
  • setup_extension() for bundled and user-given extensions
  • preload_builder (call setup_extension() for given builder-name)

As a result, app.outdir might point a non-existing directory during setup extensions.
This is surely incompatible change, but IMO it does not harm anybody.
So +1 for this!

@tk0miya tk0miya added this to the 1.7 milestone Jan 7, 2018
Copy link
Member

@shimizukawa shimizukawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tk0miya
Copy link
Member

tk0miya commented Jan 8, 2018

Thank you for your contribution!

tk0miya added a commit that referenced this pull request Jan 8, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants