Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#3620: move basic theme's DOCUMENTATION_OPTIONS to js_t #4295

Closed
wants to merge 1 commit into from
Closed

#3620: move basic theme's DOCUMENTATION_OPTIONS to js_t #4295

wants to merge 1 commit into from
+9 −10

Conversation

ghost
Copy link

@ghost ghost commented Dec 13, 2017

Subject: move basic theme's DOCUMENTATION_OPTIONS to js_t

Feature or Bugfix

  • Bugfix

Purpose

  • Removing inline javascript will allow certain users to enable CSP.

Relates

@shibukawa
Copy link
Contributor

Great Pull Request!! Thank you!

@tk0miya tk0miya changed the base branch from stable to master January 13, 2018 12:38
@tk0miya
Copy link
Member

tk0miya commented Jan 13, 2018

I changed the target to master branch. So it will be released as 1.7.

@tk0miya tk0miya added type:proposal a feature suggestion html theme labels Jan 13, 2018
@tk0miya tk0miya added this to the 1.7 milestone Jan 13, 2018
@tk0miya
Copy link
Member

tk0miya commented Jan 13, 2018

OMG, conflicts with #4245. I will fix it tomorrow.

@tk0miya
Copy link
Member

tk0miya commented Jan 14, 2018

I merged this manually: de023f2
Thank you for your contribution!

@tk0miya tk0miya closed this Jan 14, 2018
@tk0miya tk0miya mentioned this pull request Jan 14, 2018
Closed
@davidism
Copy link

This broke the search page when using the dirhtml builder. When the JS was included inline, pathto generated a url_root of ../, so that the links on the /search/ page would point to the parent dir. Now url_root is always '', so the links incorrectly point below the search page.

This was referenced Apr 29, 2018
Closed
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
html theme type:proposal a feature suggestion
Projects
None yet
Milestone
1.7
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@shibukawa @tk0miya @davidism @remyabel2