Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autodoc: Fix test expectation for enum rendering on Python 3.12.3 #12293

Conversation

jayaddison
Copy link
Contributor

Feature or Bugfix

  • Bugfix

Purpose

  • Resolve formatting expectations for the default enum sentinel value on Py3.12.3+ to fix a test that succeeeds for Py3.12.2 but fails for Py3.12.3 currently.

Detail

  • Adjust some of the Python sys.version_info checks in the test_ext_autodoc test module.

Relates

@jayaddison
Copy link
Contributor Author

I haven't yet confirmed what version(s) of Python this <not-given>-formatted sentinel was implemented for and backported to; it would be good to confirm whether it is only Py3.13+ and Py3.12.3+ that we need to consider.

@AA-Turner AA-Turner changed the title [autodoc] Fix test expectation for enum rendering on Py3.12.3 autodoc: Fix test expectation for enum rendering on Py3.12.3 Apr 17, 2024
@AA-Turner AA-Turner changed the title autodoc: Fix test expectation for enum rendering on Py3.12.3 autodoc: Fix test expectation for enum rendering on Python 3.12.3 Apr 17, 2024
@AA-Turner
Copy link
Member

I haven't yet confirmed what version(s) of Python this <not-given>-formatted sentinel was implemented for and backported to; it would be good to confirm whether it is only Py3.13+ and Py3.12.3+ that we need to consider.

The PR wasn't backported to 3.11. The relevant commits are

A

@AA-Turner AA-Turner merged commit 943f6fb into sphinx-doc:master Apr 17, 2024
22 of 23 checks passed
@jayaddison jayaddison deleted the issue-12202/enum-default-sentinel-argfmt-py3.12.3 branch April 17, 2024 08:58
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing test_enum_class with Python 3.13.0a5
2 participants