Fix regression in autodoc.Documenter.parse_name
#11613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the assert statement added in sphinx-doc#11523 fails, the build fails and the user only sees `assert matched is not None`; with this change, they will get a proper warning message containing the name of the offending module, and the build will succeed. Signed-off-by: Zack Cerza <zack@redhat.com>
|
Would love to review but it seems like I don't have the permission to do so |
|
You should be able to review via the files tab? You don't need any permissions. A |
AA-Turner
approved these changes
Aug 17, 2023
ahh I see |
AA-Turner
changed the title
autodoc.Documenter.parse_name
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the assert statement added in #11523 fails, the build fails and the user only sees
assert matched is not None; with this change, they will get a proper warning message containing the name of the offending module, and the build will succeed.