Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix layout issues in agogo theme on smaller devices #11594

Merged
merged 2 commits into from Aug 17, 2023

Conversation

lukengda
Copy link
Contributor

Subject: Fix layout issues in agogo theme on smaller devices

Feature or Bugfix

  • Feature

Purpose

  • This pull request aims to improve some layout issues in the agogo theme for devices with less screen space.
  • I provided before and after screenshots to show the effects
  • The changes can be shown on the agogo theme demo https://sphinx-themes.org/sample-sites/default-agogo/ by generating the demos or by patching the browser css.

Detail

  • fix: background colors breaking at horizontal scrolling on smaller devices
    The body now grows to fit all the content, which makes the background colors of the theme no longer break as seen below:
    sphinx-agogo-scrolling-fix-current sphinx-agogo-scrolling-fix-current
  • feature: add whitespace around the web page frame to ease the eyes on smaller screens
    The content text is very hard to read without any margin to the browser window. Modern browsers eliminated all margins from the browser side, which results in a painful reading experience for some users. The margin to the side does not affect the presentation on bigger screens where the content has auto-growing margins left and right. To make the changes appealing, the header was grown equal parts:
    sphinx-agogo-scrolling-fix-current sphinx-agogo-scrolling-fix-current

@AA-Turner
Copy link
Member

Please add a note to CHANGES

A

@lukengda lukengda force-pushed the master branch 2 times, most recently from 620c0b7 to ce137bc Compare August 16, 2023 06:31
Lukas Engelter added 2 commits August 16, 2023 08:32
…vices

The body now grows to fit all the content, which makes the background
colors of the theme no longer break
@lukengda
Copy link
Contributor Author

@AA-Turner, hope the changelog is okay like this. Thanks for taking care so quickly!

@AA-Turner AA-Turner merged commit 4dee162 into sphinx-doc:master Aug 17, 2023
27 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants