Fix sphinx.ext.autodoc.preserve_defaults extension.
#11550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I said that it would "fix" but it's not entirely true because it's unforunately impossible to recover the raw (non-evaluated) default value of a dataclass with the default |
- Add support for ``async def`` functions. - Add support for ``lambda`` functions. - Rename ``get_function_def`` to ``get_arguments`` and update its signature accordingly. Previously, ``get_function_def`` incorrectly extracted ``ast.FunctionDef`` from an arbitrary object. - Silently suppress syntax errors arising from multi-line parsing.
|
It was stupid of me to split the task into two since I would end up updating the comment. So let's fix the extension in one go. |
picnixz
force-pushed
the
fix/11543-patch-update-default-values
branch
from
6e09f0e
to
a3442ae
Compare
picnixz
force-pushed
the
fix/11543-patch-update-default-values
branch
from
a3442ae
to
36d6593
Compare
…cnixz/sphinx into fix/11543-patch-update-default-values
…pdate-default-values
…pdate-default-values
…pdate-default-values
AA-Turner
reviewed
Aug 13, 2023
…pdate-default-values
Closed
…pdate-default-values
# Conflicts: # CHANGES
AA-Turner
approved these changes
Aug 17, 2023
|
Thanks! |
# Conflicts: # CHANGES
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #11543.
Fix #11459.