Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHANGES: nitpick: credit/attribution fixup for #11431 #11547

Merged
merged 1 commit into from Aug 2, 2023

Conversation

jayaddison
Copy link
Contributor

Feature or Bugfix

  • Nitpick

Purpose

  • Fixup for an entry in the CHANGES file.

Detail

Relates

@AA-Turner AA-Turner merged commit a549c67 into sphinx-doc:master Aug 2, 2023
27 checks passed
@AA-Turner
Copy link
Member

Sorry!

AA-Turner pushed a commit that referenced this pull request Aug 2, 2023
@jayaddison
Copy link
Contributor Author

No problem :) Thanks for merging!

@jayaddison jayaddison deleted the nitpick/credit-fixup branch August 2, 2023 06:45
@picnixz
Copy link
Member

picnixz commented Aug 3, 2023

@jayaddison Oh, was it my fault? did I messed up when I changed something in vim? Sorry if it were the case !

@jayaddison
Copy link
Contributor Author

Hey @picnixz - it's ok; no idea how it happened, and I'm not planning to check the blame logs for it. The main reason I fixed it was so that anyone looking for info about the recent linkcheck refactor and related bugs could find and ping me. A secondary reason is accurate crediting, and I'm a little sensitive about that at the moment, but it's less important to me than the ease-of-contact.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants