Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove setup_command from pyproject.toml #11418

Merged
merged 2 commits into from May 12, 2023

Conversation

14mRh4X0r
Copy link
Contributor

@14mRh4X0r 14mRh4X0r commented May 12, 2023

Feature or Bugfix

  • Bugfix

Purpose

  • pyproject.toml is still referencing setup_command in places, including as entry point for distutils.commands. This breaks any invocation of setuptools involving getting information from entry points.

Detail

  • Running e.g. python setup.py --help-commands will raise ModuleNotFoundError: No module named 'sphinx.setup_command'

Relates

14mRh4X0r added a commit to 14mRh4X0r/sphinx that referenced this pull request May 12, 2023
@14mRh4X0r 14mRh4X0r changed the title Remove setup_command from pyproject.toml (#11363) Remove setup_command from pyproject.toml May 12, 2023
@AA-Turner
Copy link
Member

setup.py is considered deprecated generally, does importlib.metadata provide the same error? E.g. importlib.metadata.entry_points(group='distutils.commands').

A

@AA-Turner AA-Turner changed the base branch from master to 7.0.x May 12, 2023 13:13
AA-Turner pushed a commit to 14mRh4X0r/sphinx that referenced this pull request May 12, 2023
@AA-Turner AA-Turner merged commit de6b18a into sphinx-doc:7.0.x May 12, 2023
27 checks passed
@AA-Turner
Copy link
Member

I've released Sphinx 7.0.1 with this fix.

A

@14mRh4X0r
Copy link
Contributor Author

14mRh4X0r commented May 16, 2023

setup.py is considered deprecated generally, does importlib.metadata provide the same error? E.g. importlib.metadata.entry_points(group='distutils.commands').

Just for completeness' sake: it does, that's what setuptools calls internally (it fails on ep.load()).

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants