Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase timeout threshold for linkcheck tests #11326

Conversation

jayaddison
Copy link
Contributor

Feature or Bugfix

  • Bugfix (for flaky tests)

Purpose

Detail

  • The performance of the linkcheck tests was improved a few weeks ago (97f07ca)
  • That introduced some improved (lower) timeout thresholds that had to be adjusted a little (7d928b3)
  • A few failures remained, and that resulted in me opening issue Flaky unit tests: linkcheck builder (tests/test_build_linkcheck.py) #11299
  • I think that the changes here should allow the flaky tests to pass consistently
  • I haven't been able to find any other reason that performance would have degraded for these tests recently

Relates

@AA-Turner AA-Turner changed the title Increase timeout threshold for linkcheck tests Increase timeout threshold for linkcheck tests Apr 21, 2023
@AA-Turner AA-Turner merged commit d8f15c7 into sphinx-doc:master Apr 21, 2023
22 checks passed
@jayaddison jayaddison deleted the issue-11299/increase-linkcheck-test-timeout-threshold branch April 21, 2023 09:18
@AA-Turner AA-Turner added this to the 6.2.0 milestone Apr 29, 2023
jayaddison added a commit to jayaddison/sphinx that referenced this pull request May 3, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky unit tests: linkcheck builder (tests/test_build_linkcheck.py)
2 participants