From 60765d3e655d11ac3a9b4eabc8723c4ea8c96c7e Mon Sep 17 00:00:00 2001
From: James Addison <jay@jp-hosting.net>
Date: Fri, 5 May 2023 16:49:29 +0100
Subject: [PATCH] tests: linkcheck: add client connection-pool contention
 coverage

---
 tests/test_build_linkcheck.py | 46 ++++++++++++++++++++++++++++++++++-
 1 file changed, 45 insertions(+), 1 deletion(-)

diff --git a/tests/test_build_linkcheck.py b/tests/test_build_linkcheck.py
index acfebd64999..3f1ce383266 100644
--- a/tests/test_build_linkcheck.py
+++ b/tests/test_build_linkcheck.py
@@ -16,7 +16,12 @@
 
 import pytest
 
-from sphinx.builders.linkcheck import HyperlinkAvailabilityCheckWorker, RateLimit
+from sphinx.builders.linkcheck import (
+    CheckRequest,
+    Hyperlink,
+    HyperlinkAvailabilityCheckWorker,
+    RateLimit,
+)
 from sphinx.testing.util import strip_escseq
 from sphinx.util.console import strip_colors
 
@@ -661,6 +666,45 @@ def test_limit_rate_bails_out_after_waiting_max_time(app):
     assert next_check is None
 
 
+@mock.patch('sphinx.util.requests.requests.Session.get_adapter')
+def test_connection_contention(get_adapter, app, capsys):
+    # Create a shared, but limited-size, connection pool
+    import requests
+    get_adapter.return_value = requests.adapters.HTTPAdapter(pool_maxsize=1)
+
+    # Set an upper-bound on socket timeouts globally
+    import socket
+    socket.setdefaulttimeout(5)
+
+    # Place a workload into the linkcheck queue
+    rqueue, wqueue, link_count = Queue(), Queue(), 10
+    for _ in range(link_count):
+        wqueue.put(CheckRequest(0, Hyperlink("http://localhost:7777", "test", 1)))
+
+    # Create single-hyperlink-consumer threads
+    with http_server(make_redirect_handler(support_head=True)):
+        begin, checked = time.time(), []
+        while time.time() < begin + 5 and len(checked) < link_count:
+            worker = HyperlinkAvailabilityCheckWorker(
+                env=app.env,
+                config=app.config,
+                rqueue=rqueue,
+                wqueue=wqueue,
+                rate_limits={},
+            )
+
+            worker.start()
+            result = rqueue.get(timeout=5)
+            worker.join(timeout=0)
+
+            checked.append(result)
+
+    # Ensure that all items were consumed within the time limit
+    _, stderr = capsys.readouterr()
+    assert len(checked) == link_count
+    assert "TimeoutError" not in stderr
+
+
 class ConnectionResetHandler(http.server.BaseHTTPRequestHandler):
     def do_HEAD(self):
         self.connection.close()