Broader handling of glued roles. #61
Conversation
|
Previously only glued With this PR any character will trigger the rule. |
sphinxlint/checkers.py
Outdated
| @@ -165,7 +165,10 @@ def check_missing_space_after_role(file, lines, options=None): | |||
| # While this is not: | |||
| # The :literal:`:exc:`Exceptions``s | |||
| role_body = rf"([^`]|\s`+|\\`|:{rst.SIMPLENAME}:`([^`]|\s`+|\\`)+`)+" | |||
| suspicious_role = re.compile(f":{rst.SIMPLENAME}:`{role_body}`s") | |||
| allowed_after_role = " |" # '|' is allowed for roles in tables. | |||
There was a problem hiding this comment.
Aren't commas and other punctuation allowed too?
There was a problem hiding this comment.
You're right, I updated the list, does it looks better?
| ASCII_ALLOWED_BEFORE_INLINE_MARKUP = r"""-:/'"<(\[{""" | ||
| UNICODE_ALLOWED_BEFORE_INLINE_MARKUP = r"\p{Ps}\p{Pi}\p{Pf}\p{Pd}\p{Po}" | ||
| ASCII_ALLOWED_AFTER_INLINE_MARKUP = r"""-.,:;!?/'")\]}>""" | ||
| UNICODE_ALLOWED_AFTER_INLINE_MARKUP = r"\p{Pe}\p{Pi}\p{Pf}\p{Pd}\p{Po}" |
There was a problem hiding this comment.
FWIW all ASCII chars are technically already included in the Unicode categories, except for <> which have an Sm category. Even though they are redundant, I think it's ok since it's more explicit and it's easier to see what (ASCII) characters are allowed.
There was a problem hiding this comment.
Also this is a copy-paste from the spec: https://docutils.sourceforge.io/docs/ref/rst/restructuredtext.html#inline-markup-recognition-rules
I like copy-pasting from the spec.
Closes #60.