Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AllSettings()['flagname'] returns string for DurationSlice #1497

Closed
3 tasks done
UrbanskiDawid opened this issue Jan 24, 2023 · 3 comments · Fixed by #1498
Closed
3 tasks done

AllSettings()['flagname'] returns string for DurationSlice #1497

UrbanskiDawid opened this issue Jan 24, 2023 · 3 comments · Fixed by #1498
Labels
kind/bug Something isn't working

Comments

@UrbanskiDawid
Copy link
Contributor

Preflight Checklist

  • I have searched the issue tracker for an issue that matches the one I want to file, without success.
  • I am not looking for support or already pursued the available support channels without success.
  • I have checked the troubleshooting guide for my problem, without success.

Viper Version

1.15

Go Version

1.18

Config Source

Manual set

Format

No response

Repl.it link

No response

Code reproducing the issue

package main

import (
	"fmt"
	"time"
	"github.com/spf13/pflag"
	"github.com/spf13/viper"
)

func f1() {
	v := viper.New()

	flagSet := pflag.NewFlagSet("test", pflag.ContinueOnError)
	flagSet.String("name", "", "test")

	v.BindPFlags(flagSet)
	flagSet.VisitAll(func(flag *pflag.Flag) {
		flag.Value.Set("set")
		flag.Changed = true
	})
	fmt.Print(v.Get("name"))
}

func main() {

	flagSet := pflag.NewFlagSet("test", pflag.ContinueOnError)
	flagSet.IntSlice("ok2", []int{1, 2}, "")
	flagSet.StringSlice("ok1", []string{"s1", "s2"}, "")
	flagSet.DurationSlice("fail", []time.Duration{time.Second, time.Hour}, "")

	v := viper.New()
	v.BindPFlags(flagSet)

	ok1 := v.AllSettings()["ok1"]
	fmt.Printf("%v %T\n", ok1, ok1) //[s1 s2] []string

	ok2 := v.AllSettings()["ok2"]
	fmt.Printf("%v %T\n", ok2, ok2) //[1 2] []int

	fail := v.AllSettings()["fail"]
	fmt.Printf("%v %T\n", fail, fail) //[1s,1h0m0s] string
}

Expected Behavior

DurationSlice in AllSettings()["fail"] should return set of time.Duration in similar fashion as IntSlice and StringSlice

AllSettings()["fail"] returns:
[]time.Duration{time.Second, time.Hour}

Actual Behavior

AllSettings()["fail"] returns string
"[1s,1h0m0s]"

Steps To Reproduce

run example from this issue

Additional Information

No response

@UrbanskiDawid UrbanskiDawid added the kind/bug Something isn't working label Jan 24, 2023
@github-actions
Copy link

👋 Thanks for reporting!

A maintainer will take a look at your issue shortly. 👀

In the meantime: We are working on Viper v2 and we would love to hear your thoughts about what you like or don't like about Viper, so we can improve or fix those issues.

⏰ If you have a couple minutes, please take some time and share your thoughts: https://forms.gle/R6faU74qPRPAzchZ9

📣 If you've already given us your feedback, you can still help by spreading the news,
either by sharing the above link or telling people about this on Twitter:

https://twitter.com/sagikazarmark/status/1306904078967074816

Thank you! ❤️

@UrbanskiDawid
Copy link
Contributor Author

please note that the same issue exists for: bool slice.. and all others

@UrbanskiDawid
Copy link
Contributor Author

i have created a fix addressing this issue:
#1498

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant