New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nested classes cause UnknownNamespace.UnknownType to be outputted #48
Comments
PR for UnknownNamespace fix added here: spekt/testlogger#41. The issue mentioned about running the test multiple times is expected due to the inheritance and so this is not an issue with testlogger but more my design. Additionally, I was able to build the solution in the end but I needed to add quotes around the test asset file paths. Not sure why this seems to be required for my environment: <PropertyGroup>
<TestRestoreConfig>"$(MSBuildThisFileDirectory)../assets/NuGet.$(Configuration).config"</TestRestoreConfig>
<TestFullProject>"$(MSBuildThisFileDirectory)../assets/Xunit.Xml.TestLogger.NetFull.Tests/Xunit.Xml.TestLogger.NetFull.Tests.csproj"</TestFullProject>
<TestCoreProject>"$(MSBuildThisFileDirectory)../assets/Xunit.Xml.TestLogger.NetCore.Tests/Xunit.Xml.TestLogger.NetCore.Tests.csproj"</TestCoreProject>
</PropertyGroup> |
@pageyboy fix is available in nuget: https://www.nuget.org/packages/XunitXml.TestLogger/3.1.17. Please try it. |
Hi,
Really like the project and it has really helped with outputting test results into a legible format for our build.
However, I have run into what I think is a defect. I have taken to organizing large Test Class files into nested classes (separated by method/property etc.). After doing this and running xunit.testlogger the number of tests is misreported and the type is not reported correctly.
Happy to help out with debugging or fixing but I've struggled to get the tests to run in the solution - any advice you have here in getting your dev environment setup would be appreciated.
See below for minimum reproducible issue:
Test Class 1
Test Class 2 (separated to allow for easier navigation in VS)
These 3 tests should produce 3 test results but instead I see 4 in total and also the type as Test collection for UnknownNamespace.UnknownType for the nested classes:
The text was updated successfully, but these errors were encountered: