Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StoreConsoleOutput should be split into two options - one for testsuite and one for testcase level #164

Closed
MJB222398 opened this issue Mar 11, 2025 · 4 comments

Comments

@MJB222398
Copy link
Contributor

Is your feature request related to a problem? Please describe.
I produce fairly large test reports with a lot of content being sent to standard output. I only care about this content per test case. I do not want it being repeated at the testsuite level as my report file becomes twice as long for no real reason.

Describe the solution you'd like
I would like for two new options:

  • StoreTestCaseConsoleOutput: true/false
  • StoreTestSuiteConsoleOutput: true/false

We can retain StoreConsoleOutput option for compatibility. The value of that should be used and then overwritten if one of the two above specific ones are specified.

@codito
Copy link
Contributor

codito commented Mar 11, 2025

@MJB222398 thanks for reporting this issue. Should we enhance StoreConsoleOutput to have more values?

  • StoreConsoleOutput=true: current behavior. Both testcase and testsuite outputs are emitted.
  • StoreConsoleOutput=false: current behavior. No outputs are captured.
  • StoreConsoleOutput=testcase: only testcase output is captured.
  • StoreConsoleOutput=testsuite: only testsuite output is captured.

Would you be open to contributing a fix?

@MJB222398
Copy link
Contributor Author

MJB222398 commented Mar 11, 2025

@codito Yeah let me have a go at this.

codito pushed a commit that referenced this issue Mar 13, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…uite and testcase (#164) (#165)

* feat: Allow console output to be stored for either/both/none of testsuite and testcase (#164)

* feat: Update README for JUnit to include new StoreConsoleOutput values (#164)
@codito
Copy link
Contributor

codito commented Mar 13, 2025

@MJB222398 thanks for the PR! I will cut a release this weekend.

@codito
Copy link
Contributor

codito commented Mar 15, 2025

v6.1.0 is released to NuGet with this fix. Thanks again for your contribution!

https://www.nuget.org/packages/JunitXml.TestLogger/

@codito codito closed this as completed Mar 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants