Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: jsonpath upgrade attempt 2 #1232

Merged
merged 3 commits into from
Jan 28, 2025
Merged

Conversation

ThomasRooney
Copy link
Member

@ThomasRooney ThomasRooney commented Jan 27, 2025

This adds the ability to understand the extension x-speakeasy-jsonpath: rfc9535 to the OpenAPI Overlay document, that, if set, opts into the newer RFC9535 compliant behaviour.

It'll also automatically be added by speakeasy overlay compare, as seen in https://overlay.speakeasy.com

…mat for ts (#1230)" (unexpected additional changes)"

This reverts commit ca15aa3.
Copy link
Member

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-blocking testing feedback -- it'll be awesome to get this shipped. 🚀

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this integration test overlay also have the new annotation?

overlayFile = "testdata/overlay.yaml"
schemaJSON = "testdata/base.json"
overlayFileV1 = "testdata/overlay.yaml"
overlayFileV2 = "testdata/overlay-v2.yaml"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super nit: Might just be me, but wonder if for future travelers we should name these with "rfc9535" or "jsonpath-rfc9535" instead of "v2" (and consider "v1" -> "jsonpath-vmware") because whilst v2 makes sense at this moment it has nothing to do with a v2.0.0 of the overlay spec.

@bflad bflad merged commit 1d29866 into main Jan 28, 2025
3 checks passed
@bflad bflad deleted the chore/jsonpath-upgrade-attempt2 branch January 28, 2025 12:19
mfbx9da4 added a commit that referenced this pull request Jan 29, 2025
…studio-tweaks

* 'main' of github.com:speakeasy-api/speakeasy:
  feat: Terraform x-speakeasy-soft-delete-property, testing example.file fixes (#1233)
  chore: jsonpath upgrade attempt 2 (#1232)
  chore: Bump the github-actions-minor-and-patch group with 2 updates (#1231)
  chore: revert "feat: jsonpath upgrade, new default module format for ts (#1230)" (unexpected additional changes)
  feat: jsonpath upgrade, new default module format for ts (#1230)
  feat: make gen config path not required (#1228)
  fix: register finalizer to close httpx clients (#1229)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants