Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support more attribute targets: properties, class constants, params #225

Merged
merged 1 commit into from Dec 9, 2023
Merged

Support more attribute targets: properties, class constants, params #225

merged 1 commit into from Dec 9, 2023

Conversation

spaze
Copy link
Owner

@spaze spaze commented Dec 6, 2023

Close #224

@spaze spaze self-assigned this Dec 6, 2023
@spaze spaze mentioned this pull request Dec 6, 2023
Closed
@spaze spaze force-pushed the spaze/attributes-more-targets branch 13 times, most recently from 26dac60 to 610bc6e Compare December 9, 2023 04:19
@spaze
Support all attribute targets
d8023ee 
This adds support for properties, class constants, params, enums

Close #224
@spaze spaze force-pushed the spaze/attributes-more-targets branch from 610bc6e to d8023ee Compare December 9, 2023 04:27
@spaze spaze marked this pull request as ready for review December 9, 2023 04:33
@spaze spaze merged commit 4613004 into main Dec 9, 2023
74 checks passed
@spaze spaze deleted the spaze/attributes-more-targets branch December 9, 2023 05:05
@spaze spaze mentioned this pull request Dec 9, 2023
Closed
@francescolaffi francescolaffi mentioned this pull request Dec 11, 2023
Merged
spaze added a commit that referenced this pull request Dec 12, 2023
@spaze
disallowedAttributes: configure errorIdentifier and errorTip as optio…
a6ceaaa 
…nal (#229)

Gave a test run of some disallowed attributes on properties after #225, noticed errorIdentifier and errorTip are considered mandatory but I'm guessing it was not intended in #222.
@spaze
Copy link
Owner Author

spaze commented Dec 22, 2023

Released in 3.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@spaze spaze

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Supporting attributes restrictions on more targets, i.e. properties
1 participant
@spaze