Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "because reasons", because reasons #221

Merged
merged 3 commits into from Nov 28, 2023
Merged

Conversation

spaze
Copy link
Owner

@spaze spaze commented Nov 26, 2023

Was funny back then but maybe it's not anymore. Also it doesn't really indicate that the message could be changed. Also, the message will always end with a ., unless it ends with ? or ! already. Sorry if it breaks things for you, should have done this much earlier.

Close #220

Was funny back then but maybe it's not anymore. Also it doesn't really indicate that the message could be changed.
@spaze spaze self-assigned this Nov 26, 2023
@spaze spaze merged commit 4b952b1 into main Nov 28, 2023
74 checks passed
@spaze spaze deleted the spaze/remove-because-reasons branch November 28, 2023 01:03
@spaze
Copy link
Owner Author

spaze commented Dec 22, 2023

Released in 3.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not add ", because reasons" when no message is defined
1 participant