Method calls from interface implementations are not detected #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enumag
force-pushed
the
disallowed-interface-method
branch
from
2e1b501
to
82dbc52
Compare
|
Thanks, yeah, this isn't supported yet. But I guess it should be, it's already supported for constructors so you'd expect it to be supported for method calls as well. |
Checking interfaces is already supported for `new Class` so it makes sense to check them in calls too.
spaze
force-pushed
the
disallowed-interface-method
branch
from
82dbc52
to
4005114
Compare
|
Oh, you fixed it already. Thanks! I tried it on my side and it detects the case I need correctly now. Do you want to do something else before tagging a release? :) |
|
Yeah, wanted to sleep a bit 😅 This has now been released in 2.16.0, thanks for the help! |
|
😆 Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar case as my old PR (#26) but for interfaces.
Same as before I just added a failing test case. I didn't look for the underlying issue.
Use case: After running into guzzle/psr7#569 I wanted to disallow
Psr\Http\Message\StreamInterface::getContents()but looks like this isn't supported yet.