use SQLite3::Exception consistently
#490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[skip ci]
flavorjones
force-pushed
the
flavorjones-exec-batch-exceptions
branch
2 times, most recently
from
16f3581
to
c5f8f50
Compare
- Pragmas methods were raising StandardError - Database#execute_batch2 was raising RuntimeError - Database#load_extension was raising RuntimeError - the fallback for unknown errors was RuntimeError - use SQLite3::Exception classes consistently
flavorjones
force-pushed
the
flavorjones-exec-batch-exceptions
branch
from
c5f8f50
to
d15fdc6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use SQLite3::Exception classes consistently
Fixes #302