Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Simplify VRFSigner() method to not return an error #5147

Closed
wants to merge 1 commit into from

Conversation

poszu
Copy link
Contributor

@poszu poszu commented Oct 12, 2023

Cleanup VRFSigner() method to not return a redundant error.

@poszu
Copy link
Contributor Author

poszu commented Oct 12, 2023

bors merge

@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Merging #5147 (15ada47) into develop (8331ded) will increase coverage by 0.0%.
Report is 3 commits behind head on develop.
The diff coverage is 100.0%.

@@           Coverage Diff           @@
##           develop   #5147   +/-   ##
=======================================
  Coverage     77.5%   77.5%           
=======================================
  Files          258     258           
  Lines        30439   30427   -12     
=======================================
- Hits         23591   23582    -9     
  Misses        5336    5336           
+ Partials      1512    1509    -3     
Files Coverage Δ
beacon/beacon.go 79.2% <100.0%> (-0.1%) ⬇️
hare3/legacy_oracle.go 81.0% <100.0%> (+3.5%) ⬆️
miner/proposal_builder.go 93.6% <100.0%> (ø)
node/node.go 63.6% <100.0%> (+0.1%) ⬆️
signing/signer.go 70.0% <100.0%> (+0.5%) ⬆️

... and 3 files with indirect coverage changes

bors bot pushed a commit that referenced this pull request Oct 12, 2023
Cleanup `VRFSigner()` method to not return a redundant error.
@bors
Copy link

bors bot commented Oct 12, 2023

Pull request successfully merged into develop.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title Simplify VRFSigner() method to not return an error [Merged by Bors] - Simplify VRFSigner() method to not return an error Oct 12, 2023
@bors bors bot closed this Oct 12, 2023
@bors bors bot deleted the cleanup-vrfsigner branch October 12, 2023 12:54
dshulyak pushed a commit to dshulyak/go-spacemesh that referenced this pull request Oct 13, 2023
Cleanup `VRFSigner()` method to not return a redundant error.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants