Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - p2p: add back disable dht option #5111

Closed
wants to merge 1 commit into from

Conversation

countvonzero
Copy link
Contributor

Motivation

p2p option disable-dht was removed by mistake

@countvonzero
Copy link
Contributor Author

bors merge

@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

Merging #5111 (f2efa7a) into develop (3b1b118) will decrease coverage by 0.1%.
The diff coverage is 15.7%.

@@            Coverage Diff            @@
##           develop   #5111     +/-   ##
=========================================
- Coverage     77.0%   77.0%   -0.1%     
=========================================
  Files          257     257             
  Lines        30287   30296      +9     
=========================================
- Hits         23349   23346      -3     
- Misses        5413    5424     +11     
- Partials      1525    1526      +1     
Files Coverage Δ
p2p/host.go 47.3% <ø> (ø)
p2p/upgrade.go 63.6% <0.0%> (-1.3%) ⬇️
p2p/dhtdiscovery/discovery.go 72.0% <18.7%> (-1.4%) ⬇️

... and 6 files with indirect coverage changes

bors bot pushed a commit that referenced this pull request Sep 28, 2023
## Motivation
p2p option disable-dht was removed by mistake
@bors
Copy link

bors bot commented Sep 28, 2023

Pull request successfully merged into develop.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title p2p: add back disable dht option [Merged by Bors] - p2p: add back disable dht option Sep 28, 2023
@bors bors bot closed this Sep 28, 2023
@bors bors bot deleted the add-back-disable-dht branch September 28, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants