Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - generator doesn't need to recompute eligibility count and loop over atxs #5105

Conversation

dshulyak
Copy link
Contributor

@dshulyak dshulyak commented Sep 27, 2023

closes: #5077

@dshulyak dshulyak force-pushed the refactor-blocks-without-cache-looping branch from c366f9d to b7e8b1c Compare September 27, 2023 13:03
@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Merging #5105 (dddf714) into develop (7572d41) will increase coverage by 0.0%.
Report is 2 commits behind head on develop.
The diff coverage is 50.0%.

@@           Coverage Diff           @@
##           develop   #5105   +/-   ##
=======================================
  Coverage     77.1%   77.1%           
=======================================
  Files          257     257           
  Lines        30335   30301   -34     
=======================================
- Hits         23391   23370   -21     
+ Misses        5415    5407    -8     
+ Partials      1529    1524    -5     
Files Coverage Δ
proposals/util.go 86.3% <ø> (ø)
proposals/util/util.go 100.0% <ø> (+26.7%) ⬆️
blocks/utils.go 85.9% <50.0%> (-2.0%) ⬇️

... and 5 files with indirect coverage changes

@dshulyak
Copy link
Contributor Author

bors merge

bors bot pushed a commit that referenced this pull request Sep 27, 2023
@bors
Copy link

bors bot commented Sep 27, 2023

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Sep 27, 2023
@bors
Copy link

bors bot commented Sep 27, 2023

Build failed:

@countvonzero
Copy link
Contributor

bors merge

bors bot pushed a commit that referenced this pull request Sep 27, 2023
@bors
Copy link

bors bot commented Sep 27, 2023

Build failed:

@countvonzero
Copy link
Contributor

bors merge

bors bot pushed a commit that referenced this pull request Sep 27, 2023
@bors
Copy link

bors bot commented Sep 28, 2023

Pull request successfully merged into develop.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title generator doesn't need to recompute eligibility count and loop over atxs [Merged by Bors] - generator doesn't need to recompute eligibility count and loop over atxs Sep 28, 2023
@bors bors bot closed this Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use consensus cache in block generator when computing rewards
2 participants