[Merged by Bors] - Deflake tests by giving nipost builder more time in tests #5101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fasmat
requested review from
countvonzero,
dshulyak and
poszu
as code owners
fasmat
force-pushed
the
5060-fix-flaky-nipost-tests
branch
from
431a98c
to
d7657a6
Compare
Codecov Report
@@ Coverage Diff @@
## develop #5101 +/- ##
=======================================
Coverage 77.0% 77.1%
=======================================
Files 257 257
Lines 30278 30278
=======================================
+ Hits 23331 23348 +17
+ Misses 5421 5403 -18
- Partials 1526 1527 +1 |
fasmat
changed the title
countvonzero
approved these changes
Sep 27, 2023
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Sep 27, 2023
## Motivation Closes #5060 Deflakes `TestValidator_Validate` and `TestNIPostBuilderWithClients` ## Changes - Extend timeouts to avoid tests failing because of them ## Test Plan n/a ## TODO <!-- This section should be removed when all items are complete --> - [x] Explain motivation or link existing issue(s) - [x] Test changes and document test plan - [x] Update documentation as needed - [x] Update [changelog](../CHANGELOG.md) as needed
|
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
Sep 27, 2023
## Motivation Closes #5060 Deflakes `TestValidator_Validate` and `TestNIPostBuilderWithClients` ## Changes - Extend timeouts to avoid tests failing because of them ## Test Plan n/a ## TODO <!-- This section should be removed when all items are complete --> - [x] Explain motivation or link existing issue(s) - [x] Test changes and document test plan - [x] Update documentation as needed - [x] Update [changelog](../CHANGELOG.md) as needed
|
Pull request successfully merged into develop. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #5060
Deflakes
TestValidator_ValidateandTestNIPostBuilderWithClientsChanges
Test Plan
n/a
TODO