New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Completely remove github.com/golang/protobuf dependency #5098
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #5098 +/- ##
=======================================
Coverage 77.0% 77.0%
=======================================
Files 257 257
Lines 30278 30278
=======================================
+ Hits 23328 23343 +15
+ Misses 5423 5407 -16
- Partials 1527 1528 +1
|
bors merge |
## Motivation Follow up to #5092. This completely removes `github.com/golang/protobuf` as a direct dependency. ## Changes - Replace `github.com/golang/protobuf` with `google.golang.org/protobuf` ## Test Plan <!-- Please specify how these changes were tested (e.g. unit tests, manual testing, etc.) --> ## TODO <!-- This section should be removed when all items are complete --> - [x] Explain motivation or link existing issue(s) - [x] Test changes and document test plan - [x] Update documentation as needed - [x] Update [changelog](../CHANGELOG.md) as needed
Build failed: |
bors merge |
## Motivation Follow up to #5092. This completely removes `github.com/golang/protobuf` as a direct dependency. ## Changes - Replace `github.com/golang/protobuf` with `google.golang.org/protobuf` ## Test Plan <!-- Please specify how these changes were tested (e.g. unit tests, manual testing, etc.) --> ## TODO <!-- This section should be removed when all items are complete --> - [x] Explain motivation or link existing issue(s) - [x] Test changes and document test plan - [x] Update documentation as needed - [x] Update [changelog](../CHANGELOG.md) as needed
Pull request successfully merged into develop. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page.
|
Motivation
Follow up to #5092. This completely removes
github.com/golang/protobuf
as a direct dependency.Changes
github.com/golang/protobuf
withgoogle.golang.org/protobuf
Test Plan
TODO