Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Completely remove github.com/golang/protobuf dependency #5098

Closed
wants to merge 1 commit into from

Conversation

fasmat
Copy link
Member

@fasmat fasmat commented Sep 27, 2023

Motivation

Follow up to #5092. This completely removes github.com/golang/protobuf as a direct dependency.

Changes

  • Replace github.com/golang/protobuf with google.golang.org/protobuf

Test Plan

TODO

  • Explain motivation or link existing issue(s)
  • Test changes and document test plan
  • Update documentation as needed
  • Update changelog as needed

@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Merging #5098 (55bc546) into develop (41434a0) will increase coverage by 0.0%.
The diff coverage is 100.0%.

@@           Coverage Diff           @@
##           develop   #5098   +/-   ##
=======================================
  Coverage     77.0%   77.0%           
=======================================
  Files          257     257           
  Lines        30278   30278           
=======================================
+ Hits         23328   23343   +15     
+ Misses        5423    5407   -16     
- Partials      1527    1528    +1     
Files Coverage Δ
api/grpcserver/activation_service.go 77.3% <100.0%> (ø)
api/grpcserver/admin_service.go 65.1% <100.0%> (ø)
api/grpcserver/debug_service.go 73.9% <100.0%> (ø)
api/grpcserver/node_service.go 65.7% <100.0%> (ø)
api/grpcserver/smesher_service.go 74.7% <100.0%> (ø)

... and 3 files with indirect coverage changes

@fasmat
Copy link
Member Author

fasmat commented Sep 27, 2023

bors merge

bors bot pushed a commit that referenced this pull request Sep 27, 2023
## Motivation
Follow up to #5092. This completely removes `github.com/golang/protobuf` as a direct dependency.

## Changes
- Replace `github.com/golang/protobuf` with `google.golang.org/protobuf`

## Test Plan
<!-- Please specify how these changes were tested
(e.g. unit tests, manual testing, etc.) -->

## TODO
<!-- This section should be removed when all items are complete -->
- [x] Explain motivation or link existing issue(s)
- [x] Test changes and document test plan
- [x] Update documentation as needed
- [x] Update [changelog](../CHANGELOG.md) as needed
@bors
Copy link

bors bot commented Sep 27, 2023

Build failed:

@fasmat
Copy link
Member Author

fasmat commented Sep 27, 2023

make install failed on one runner

bors merge

bors bot pushed a commit that referenced this pull request Sep 27, 2023
## Motivation
Follow up to #5092. This completely removes `github.com/golang/protobuf` as a direct dependency.

## Changes
- Replace `github.com/golang/protobuf` with `google.golang.org/protobuf`

## Test Plan
<!-- Please specify how these changes were tested
(e.g. unit tests, manual testing, etc.) -->

## TODO
<!-- This section should be removed when all items are complete -->
- [x] Explain motivation or link existing issue(s)
- [x] Test changes and document test plan
- [x] Update documentation as needed
- [x] Update [changelog](../CHANGELOG.md) as needed
@bors
Copy link

bors bot commented Sep 27, 2023

Pull request successfully merged into develop.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title Completely remove github.com/golang/protobuf dependency [Merged by Bors] - Completely remove github.com/golang/protobuf dependency Sep 27, 2023
@bors bors bot closed this Sep 27, 2023
@bors bors bot deleted the remove-golang-protobuf branch September 27, 2023 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants